pgsql: Fix another instance of unsafe coding for shm_toc_lookup failure

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Fix another instance of unsafe coding for shm_toc_lookup failure
Date: 2018-02-02 23:32:15
Message-ID: E1ehkoZ-0005uW-43@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox
Thread:
Lists: pgsql-committers

Fix another instance of unsafe coding for shm_toc_lookup failure.

One or another author of commit 5bcf389ec seems to have thought that
computing an offset from a NULL pointer would yield another NULL pointer.
There may possibly be architectures where that works, but common machines
don't work like that. Per a quick code review of places calling
shm_toc_lookup and not using noError = false.

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/d59ff4ab3111f20054425d82dab1393101dcfe8e

Modified Files
--------------
src/backend/executor/nodeHash.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Thomas Munro 2018-02-03 01:59:30 Re: pgsql: Fix another instance of unsafe coding for shm_toc_lookup failure
Previous Message Tom Lane 2018-02-02 22:10:51 pgsql: First-draft release notes for 10.2.