pgsql: PL/Python: Simplify PLyLong_FromInt64

From: Peter Eisentraut <peter_e(at)gmx(dot)net>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: PL/Python: Simplify PLyLong_FromInt64
Date: 2018-01-19 22:31:12
Message-ID: E1ecfBo-0007lL-Kv@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

PL/Python: Simplify PLyLong_FromInt64

We don't actually need two code paths, one for 32 bits and one for 64
bits. Since the existing code already assumed that "long long" is
available, we can just use PyLong_FromLongLong() for 64 bits as well.
In Python 2.5 and later, PyLong_FromLong() and PyLong_FromLongLong() use
the same code, so there will be no difference for 64-bit platforms. In
Python 2.4, the code is different, but performance testing showed no
noticeable difference in PL/Python, and that Python version is ancient
anyway.

Discussion: https://www.postgresql.org/message-id/0a02203c-e157-55b2-464e-6087066a1849@2ndquadrant.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/eee50a8d4c389171ad5180568a7221f7e9b28f09

Modified Files
--------------
src/pl/plpython/plpy_typeio.c | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2018-01-20 03:16:28 pgsql: Suppress possibly-uninitialized-variable warnings.
Previous Message Robert Haas 2018-01-19 20:33:38 pgsql: Allow UPDATE to move rows between partitions.