pgsql: Rename pg_rewind's copy_file_range() to avoid conflict with new

From: Andres Freund <andres(at)anarazel(dot)de>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Rename pg_rewind's copy_file_range() to avoid conflict with new
Date: 2018-01-03 20:41:17
Message-ID: E1eWpqf-00068A-FJ@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Rename pg_rewind's copy_file_range() to avoid conflict with new linux syscall.

Upcoming versions of glibc will contain copy_file_range(2), a wrapper
around a new linux syscall for in-kernel copying of data ranges. This
conflicts with pg_rewinds function of the same name.

Therefore rename pg_rewinds version. As our version isn't a generic
copying facility we decided to choose a rewind specific function name.

Per buildfarm animal caiman and subsequent discussion with Tom Lane.

Author: Andres Freund
Discussion:
https://postgr.es/m/20180103033425.w7jkljth3e26sduc@alap3.anarazel.de
https://postgr.es/m/31122.1514951044@sss.pgh.pa.us
Backpatch: 9.5-, where pg_rewind was introduced

Branch
------
REL9_5_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/ea4cbf8f1050b490d3040e659598bee63494288d

Modified Files
--------------
src/bin/pg_rewind/copy_fetch.c | 9 +++++----
1 file changed, 5 insertions(+), 4 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Alvaro Herrera 2018-01-03 21:24:41 pgsql: Revert "Fix isolation test to be less timing-dependent"
Previous Message Andres Freund 2018-01-03 20:41:16 pgsql: Rename pg_rewind's copy_file_range() to avoid conflict with new