pgsql: Teach eval_const_expressions() to handle some more cases.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Teach eval_const_expressions() to handle some more cases.
Date: 2018-01-03 17:35:26
Message-ID: E1eWmwo-0002MN-Mp@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Teach eval_const_expressions() to handle some more cases.

Add some infrastructure (mostly macros) to make it easier to write
typical cases for constant-expression simplification. Add simplification
processing for ArrayRef, RowExpr, and ScalarArrayOpExpr node types,
which formerly went unsimplified even if all their inputs were constants.
Also teach it to simplify FieldSelect from a composite constant.
Make use of the new infrastructure to reduce the amount of code needed
for the existing ArrayExpr and ArrayCoerceExpr cases.

One existing test case changes output as a result of the fact that
RowExpr can now be folded to a constant. All the new code is exercised
by existing test cases according to gcov, so I feel no need to add
additional tests.

Tom Lane, reviewed by Dmitry Dolgov

Discussion: https://postgr.es/m/3be3b82c-e29c-b674-2163-bf47d98817b1@iki.fi

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/3decd150a2d5a8f8d43010dd0c207746ba946303

Modified Files
--------------
src/backend/optimizer/util/clauses.c | 219 ++++++++++++++++++++++-----------
src/test/regress/expected/rowtypes.out | 6 +-
2 files changed, 150 insertions(+), 75 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2018-01-03 17:53:54 pgsql: Fix some minor errors in new PHJ code.
Previous Message Peter Eisentraut 2018-01-03 15:14:24 pgsql: Allow ldaps when using ldap authentication