pgsql: Cancel CV sleep during subtransaction abort.

From: Robert Haas <rhaas(at)postgresql(dot)org>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Cancel CV sleep during subtransaction abort.
Date: 2017-12-21 14:25:03
Message-ID: E1eS1mR-0002Jn-PN@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Cancel CV sleep during subtransaction abort.

Generally, error recovery paths that need to do things like
LWLockReleaseAll and pgstat_report_wait_end also need to call
ConditionVariableCancelSleep, but AbortSubTransaction was missed.

Since subtransaction abort might destroy up the DSM segment that
contains the ConditionVariable stored in cv_sleep_target, this
can result in a crash for anything using condition variables.

Reported and diagnosed by Andres Freund.

Discussion: http://postgr.es/m/20171221110048.rxk6464azzl5t2fi@alap3.anarazel.de

Branch
------
REL_10_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/f3decdc94ea3dea05715325757db7b0295672bbe

Modified Files
--------------
src/backend/access/transam/xact.c | 3 +++
1 file changed, 3 insertions(+)

Browse pgsql-committers by date

  From Date Subject
Next Message Robert Haas 2017-12-21 14:25:27 Re: condition variable cleanup and subtransactions
Previous Message Thomas Munro 2017-12-21 12:48:59 Re: pgsql: Add parallel-aware hash joins.