| From: | Noah Misch <noah(at)leadboat(dot)com> |
|---|---|
| To: | pgsql-committers(at)postgresql(dot)org |
| Subject: | pgsql: Avoid and detect SIGPIPE race in TAP tests. |
| Date: | 2017-12-16 18:05:36 |
| Message-ID: | E1eQGq8-0000dV-5f@gemulon.postgresql.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Avoid and detect SIGPIPE race in TAP tests.
Don't write to stdin of a psql process that could have already exited
with an authentication failure. Buildfarm members crake and mandrill
have failed once by doing so. Ignore SIGPIPE in all TAP tests.
Back-patch to v10, where these tests were introduced.
Reviewed by Michael Paquier.
Discussion: https://postgr.es/m/20171209210203.GC3362632@rfd.leadboat.com
Branch
------
REL_10_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/ac93acbc05be2ef995208c1ca17f8083f60ccc53
Modified Files
--------------
src/test/authentication/t/001_password.pl | 3 +--
src/test/authentication/t/002_saslprep.pl | 3 +--
src/test/perl/TestLib.pm | 4 ++++
3 files changed, 6 insertions(+), 4 deletions(-)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2017-12-16 20:57:00 | pgsql: Try to detect runtime unavailability of __builtin_mul_overflow(i |
| Previous Message | Tom Lane | 2017-12-16 16:32:55 | pgsql: Fix oversights in new plpgsql test suite infrastructure. |