pgsql: PL/Python: Fix potential NULL pointer dereference

From: Peter Eisentraut <peter_e(at)gmx(dot)net>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: PL/Python: Fix potential NULL pointer dereference
Date: 2017-11-28 16:31:18
Message-ID: E1eJin0-0002iK-Ge@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

PL/Python: Fix potential NULL pointer dereference

After d0aa965c0a0ac2ff7906ae1b1dad50a7952efa56, one error path in
PLy_spi_execute_fetch_result() could result in the variable "result"
being dereferenced after being set to NULL. To fix that, just clear the
resources right there and return early.

Also add another SPI_freetuptable() call so that that is cleared in all
error paths.

discovered by John Naylor <jcnaylor(at)gmail(dot)com> via scan-build

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/e42e2f38907681c48c43f49c5ec9f9f41a9aa9a5

Modified Files
--------------
src/pl/plpython/plpy_spi.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2017-11-28 16:35:37 Re: pgsql: PL/Python: Fix potential NULL pointer dereference
Previous Message Robert Haas 2017-11-28 15:51:06 pgsql: Add null test to partition constraint for default range partitio