pgsql: pgbench: fix stats reporting when some transactions are skipped.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: pgbench: fix stats reporting when some transactions are skipped.
Date: 2017-11-21 22:30:54
Message-ID: E1eHH4A-0000Ag-39@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

pgbench: fix stats reporting when some transactions are skipped.

pgbench can skip some transactions when both -R and -L options are used.
Previously, this resulted in slightly silly statistics both in progress
reports and final output, because the skipped transactions were counted
as executed for TPS and related stats. Discount skipped xacts in TPS
numbers, and also when figuring the percentage of xacts exceeding the
latency limit.

Also, don't print per-script skipped-transaction counts when there is
only one script. That's redundant with the overall count, and it's
inconsistent with the fact that we don't print other per-script stats
when there's only one script. Clean up some unnecessary interactions
between what should be independent options that were due to that
decision.

While at it, avoid division-by-zero in cases where no transactions were
executed. While on modern platforms this would generally result in
printing "NaN" rather than a crash, that isn't spelled consistently
across platforms and it would confuse many people. Skip the relevant
output entirely when practical, else print zeroes.

Fabien Coelho, reviewed by Steve Singer, additional hacking by me

Discussion: https://postgr.es/m/26654.1505232433@sss.pgh.pa.us

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/16827d442448d1935ed644e944a4cb8213345351

Modified Files
--------------
doc/src/sgml/ref/pgbench.sgml | 3 +-
src/bin/pgbench/pgbench.c | 104 ++++++++++++++++-----------
src/bin/pgbench/t/001_pgbench_with_server.pl | 2 +-
3 files changed, 65 insertions(+), 44 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Michael Paquier 2017-11-22 01:11:17 Re: [HACKERS] [COMMITTERS] pgsql: Fix freezing of a dead HOT-updated tuple
Previous Message Robert Haas 2017-11-21 19:47:39 pgsql: Provide for forward compatibility with future minor protocol ver