pgsql: Fix misimplementation of typcache logic for extended hashing.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Fix misimplementation of typcache logic for extended hashing.
Date: 2017-10-20 20:08:23
Message-ID: E1e5dah-00075h-0I@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Fix misimplementation of typcache logic for extended hashing.

The previous coding would report that an array type supports extended
hashing if its element type supports regular hashing. This bug is
only latent at the moment, since AFAICS there is not yet any code
that depends on checking presence of extended-hashing support to make
any decisions. (And in any case it wouldn't matter unless the element
type has only regular hashing, which isn't true of any core data type.)
But that doesn't make it less broken. Extend the
cache_array_element_properties infrastructure to check this properly.

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/a8f1efc8ace228b5258ee7d06eace923007072c4

Modified Files
--------------
src/backend/utils/cache/typcache.c | 59 +++++++++++++++++++++++---------------
1 file changed, 36 insertions(+), 23 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2017-10-20 21:12:54 pgsql: Fix typcache's failure to treat ranges as container types.
Previous Message Robert Haas 2017-10-20 13:44:12 pgsql: pg_stat_statements: Add a comment about the dangers of padding b