From: | Andres Freund <andres(at)anarazel(dot)de> |
---|---|
To: | pgsql-committers(at)postgresql(dot)org |
Subject: | pgsql: Allow to avoid NUL-byte management for stringinfos and use in fo |
Date: | 2017-10-11 23:11:15 |
Message-ID: | E1e2Q9j-000185-L8@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Allow to avoid NUL-byte management for stringinfos and use in format.c.
In a lot of the places having appendBinaryStringInfo() maintain a
trailing NUL byte wasn't actually meaningful, e.g. when appending an
integer which can contain 0 in one of its bytes.
Removing this yields some small speedup, but more importantly will be
more consistent when providing faster variants of pq_sendint etc.
Author: Andres Freund
Discussion: https://postgr.es/m/20170914063418.sckdzgjfrsbekae4@alap3.anarazel.de
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/70c2d1be2b1e1efa8ef38a92b443fa290a9558dd
Modified Files
--------------
src/backend/lib/stringinfo.c | 21 ++++++++++++++++++++-
src/backend/libpq/pqformat.c | 18 +++++++++---------
src/include/lib/stringinfo.h | 8 ++++++++
3 files changed, 37 insertions(+), 10 deletions(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Andres Freund | 2017-10-11 23:35:39 | pgsql: Use one stringbuffer for all rows printed in printtup.c. |
Previous Message | Tom Lane | 2017-10-11 21:47:29 | Re: pgsql: Remove unnecessary PG_TRY overhead for CurrentResourceOwner chan |