pgsql: Fix intra-query memory leakage in nodeProjectSet.c.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Fix intra-query memory leakage in nodeProjectSet.c.
Date: 2017-10-06 18:28:47
Message-ID: E1e0XMd-0002Gp-IS@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Fix intra-query memory leakage in nodeProjectSet.c.

Both ExecMakeFunctionResultSet() and evaluation of simple expressions
need to be done in the per-tuple memory context, not per-query, else
we leak data until end of query. This is a consideration that was
missed while refactoring code in the ProjectSet patch (note that in
pre-v10, ExecMakeFunctionResult is called in the per-tuple context).

Per bug #14843 from Ben M. Diagnosed independently by Andres and myself.

Discussion: https://postgr.es/m/20171005230321.28561.15927@wrigleys.postgresql.org

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/a1c2c430d33e0945da234b025b78bd265c8bdfb5

Modified Files
--------------
src/backend/executor/execSRF.c | 2 ++
src/backend/executor/nodeProjectSet.c | 6 ++++++
2 files changed, 8 insertions(+)

Browse pgsql-committers by date

  From Date Subject
Next Message Peter Geoghegan 2017-10-06 18:34:20 Re: [COMMITTERS] pgsql: Fix freezing of a dead HOT-updated tuple
Previous Message Peter Geoghegan 2017-10-06 18:07:45 Re: [COMMITTERS] pgsql: Fix freezing of a dead HOT-updated tuple