pgsql: Fix assorted portability issues in new pgbench TAP tests.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Fix assorted portability issues in new pgbench TAP tests.
Date: 2017-09-08 15:28:06
Message-ID: E1dqLCQ-0004TY-6Z@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

Fix assorted portability issues in new pgbench TAP tests.

* Our own version of getopt_long doesn't support abbreviation of
long options.

* It doesn't do automatic rearrangement of non-option arguments to the end,
either.

* Test was way too optimistic about the platform independence of
NaN and Infinity outputs. I rather imagine we might have to lose
those tests altogether, but for the moment just allow case variation
and fully spelled out Infinity.

Per buildfarm.

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/869aa40a27fa4908ad4112f1079bf732d1a12e13

Modified Files
--------------
src/bin/pgbench/t/001_pgbench_with_server.pl | 11 ++++-------
src/bin/pgbench/t/002_pgbench_no_server.pl | 2 +-
2 files changed, 5 insertions(+), 8 deletions(-)

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Fabien COELHO 2017-09-08 15:53:03 Re: pgsql: Fix assorted portability issues in new pgbench TAP tests.
Previous Message Tom Lane 2017-09-08 13:32:59 pgsql: Add much-more-extensive TAP tests for pgbench.

Browse pgsql-hackers by date

  From Date Subject
Next Message Jesper Pedersen 2017-09-08 15:33:35 Re: Fix performance degradation of contended LWLock on NUMA
Previous Message Fabien COELHO 2017-09-08 14:18:55 Re: pgbench tap tests & minor fixes.