pgsql: Correct base backup throttling

From: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Correct base backup throttling
Date: 2017-09-05 15:40:26
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-committers

Correct base backup throttling

Throttling for sending a base backup in walsender is broken for the case
where there is a lot of WAL traffic, because the latch used to put the
walsender to sleep is also signalled by regular WAL traffic (and each
signal causes an additional batch of data to be sent); the net effect is
that there is no or little actual throttling. This is undesirable, so
rewrite the sleep into a loop to achieve the desired effeect.

Author: Jeff Janes, small tweaks by me
Reviewed-by: Antonin Houska



Modified Files
src/backend/replication/basebackup.c | 37 +++++++++++++++++++++++++-----------
1 file changed, 26 insertions(+), 11 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2017-09-05 16:02:29 pgsql: In psql, use PSQL_PAGER in preference to PAGER, if it's set.
Previous Message Simon Riggs 2017-09-05 15:29:15 Re: pgsql: Add psql variables showing server version and psql version.