pgsql: Make [U]INT64CONST safe for use in #if conditions.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Make [U]INT64CONST safe for use in #if conditions.
Date: 2017-09-01 19:14:55
Message-ID: E1dnrP5-0007ao-Ti@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox
Thread:
Lists: pgsql-committers

Make [U]INT64CONST safe for use in #if conditions.

Instead of using a cast to force the constant to be the right width,
assume we can plaster on an L, UL, LL, or ULL suffix as appropriate.
The old approach to this is very hoary, dating from before we were
willing to require compilers to have working int64 types.

This fix makes the PG_INT64_MIN, PG_INT64_MAX, and PG_UINT64_MAX
constants safe to use in preprocessor conditions, where a cast
doesn't work. Other symbolic constants that might be defined using
[U]INT64CONST are likewise safer than before.

Also fix the SIZE_MAX macro to be similarly safe, if we are forced
to provide a definition for that. The test added in commit 2e70d6b5e
happens to do what we want even with the hack "(size_t) -1" definition,
but we could easily get burnt on other tests in future.

Back-patch to all supported branches, like the previous commits.

Discussion: https://postgr.es/m/15883.1504278595@sss.pgh.pa.us

Branch
------
REL9_6_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/3a0f8e7d3f9a54ab34b69d1fc8c9f7806d67521a

Modified Files
--------------
configure | 18 ------------------
configure.in | 12 ------------
src/include/c.h | 21 ++++++++++-----------
src/include/pg_config.h.in | 4 ----
src/include/pg_config.h.win32 | 8 +-------
5 files changed, 11 insertions(+), 52 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Robert Haas 2017-09-01 19:19:20 pgsql: Tighten up some code in RelationBuildPartitionDesc.
Previous Message Peter Eisentraut 2017-09-01 18:20:44 pgsql: doc: Remove mentions of server-side CRL and CA file names