pgsql: Code review for pushing LIMIT through subqueries.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Code review for pushing LIMIT through subqueries.
Date: 2017-08-25 13:05:32
Message-ID: E1dlEIm-0007FF-PO@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Code review for pushing LIMIT through subqueries.

Minor improvements for commit 1f6d515a6. We do not need the (rather
expensive) test for SRFs in the targetlist, because since v10 any
such SRFs would appear in separate ProjectSet nodes. Also, make the
code look more like the existing cases by turning it into a simple
recursion --- the argument that there might be some performance
benefit to contorting the code seems unfounded to me, especially since
any good compiler should turn the tail-recursion into iteration anyway.

Discussion: http://postgr.es/m/CADE5jYLuugnEEUsyW6Q_4mZFYTxHxaVCQmGAsF0yiY8ZDggi-w@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/3f4c7917b3bc8b421c0c85cb9995974c55e7232b

Modified Files
--------------
src/backend/executor/nodeLimit.c | 58 +++++++++++++++++++++-------------------
1 file changed, 30 insertions(+), 28 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Michael Meskes 2017-08-25 13:42:32 pgsql: Implement DO CONTINUE action for ECPG WHENEVER statement.
Previous Message Michael Paquier 2017-08-25 08:11:26 Re: Re: [COMMITTERS] pgsql: Fix bug that can cause walsender not to terminating at shutdown.