pgsql: Improve comments about partitioned hash table freelists.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Improve comments about partitioned hash table freelists.
Date: 2017-07-22 22:02:31
Message-ID: E1dZ2Tn-0005BX-3r@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Improve comments about partitioned hash table freelists.

While I couldn't find any live bugs in commit 44ca4022f, the comments
seemed pretty far from adequate; in particular it was not made plain that
"borrowing" entries from other freelists is critical for correctness.
Try to improve the commentary. A couple of very minor code style
tweaks, as well.

Discussion: https://postgr.es/m/10593.1500670709@sss.pgh.pa.us

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/ab2324fd468c4bc6d8b012552550ed951d97339a

Modified Files
--------------
src/backend/utils/hash/dynahash.c | 105 +++++++++++++++++++++++++-------------
1 file changed, 70 insertions(+), 35 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2017-07-23 00:20:36 pgsql: Fix pg_dump's handling of event triggers.
Previous Message Tom Lane 2017-07-22 16:15:35 pgsql: Update expected results for collate.linux.utf8 regression test.