From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | pgsql-committers(at)postgresql(dot)org |
Subject: | pgsql: Improve TAP test function PostgresNode::poll_query_until(). |
Date: | 2017-07-02 18:03:49 |
Message-ID: | E1dRjDp-0000cD-Ks@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Improve TAP test function PostgresNode::poll_query_until().
Add an optional "expected" argument to override the default assumption
that we're waiting for the query to return "t". This allows replacing
a handwritten polling loop in recovery/t/007_sync_rep.pl with use of
poll_query_until(); AFAICS that's the only remaining ad-hoc polling
loop in our TAP tests.
Change poll_query_until() to probe ten times per second not once per
second. Like some similar changes I've been making recently, the
one-second interval seems to be rooted in ancient traditions rather
than the actual likely wait duration on modern machines. I'd consider
reducing it further if there were a convenient way to spawn just one
psql for the whole loop rather than one per probe attempt.
Discussion: https://postgr.es/m/12486.1498938782@sss.pgh.pa.us
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/de3de0afd7da7b432e219aa38bde248fc5c5206a
Modified Files
--------------
src/test/perl/PostgresNode.pm | 29 ++++++++++++++++++-----------
src/test/recovery/t/007_sync_rep.pl | 21 ++-------------------
2 files changed, 20 insertions(+), 30 deletions(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2017-07-02 19:27:35 | pgsql: Try to improve readability of recovery/t/009_twophase.pl test. |
Previous Message | Peter Eisentraut | 2017-07-02 04:12:44 | pgsql: doc: Document that logical replication supports synchronous repl |