| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | pgsql-committers(at)postgresql(dot)org |
| Subject: | pgsql: Don't downcase entries within shared_preload_libraries et al. |
| Date: | 2017-06-20 17:03:43 |
| Message-ID: | E1dNMZ5-0001i3-VO@gemulon.postgresql.org |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Don't downcase entries within shared_preload_libraries et al.
load_libraries(), which processes the various xxx_preload_libraries GUCs,
was parsing them using SplitIdentifierString() which isn't really
appropriate for values that could be path names: it downcases unquoted
text, and it doesn't allow embedded whitespace unless quoted.
Use SplitDirectoriesString() instead. That also allows us to simplify
load_libraries() a bit, since canonicalize_path() is now done for it.
While this definitely seems like a bug fix, it has the potential to
break configuration settings that accidentally worked before because
of the downcasing behavior. Also, there's an easy workaround for the
bug, namely to double-quote troublesome text. Hence, no back-patch.
QL Zhuo, tweaked a bit by me
Discussion: https://postgr.es/m/CAB-oJtxHVDc3H+Km3CjB9mY1VDzuyaVH_ZYSz7iXcRqCtb93Ew@mail.gmail.com
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/a69dfe5f40f77d586e8d4d9ecfc39d81612c7dda
Modified Files
--------------
src/backend/utils/adt/varlena.c | 4 +++-
src/backend/utils/init/miscinit.c | 21 +++++++++------------
2 files changed, 12 insertions(+), 13 deletions(-)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bruce Momjian | 2017-06-20 17:20:16 | pgsql: pg_upgrade: start/stop new server after pg_resetwal |
| Previous Message | Peter Eisentraut | 2017-06-20 16:36:20 | pgsql: Tweak publication fetching in psql |