pgsql: On Windows, make pg_dump use binary mode for compressed plain te

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: On Windows, make pg_dump use binary mode for compressed plain te
Date: 2017-06-19 15:03:51
Message-ID: E1dMyDX-0006Fw-0k@gemulon.postgresql.org
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-committers

On Windows, make pg_dump use binary mode for compressed plain text output.

The combination of -Z -Fp and output to stdout resulted in corrupted
output data, because we left stdout in text mode, resulting in newline
conversion being done on the compressed stream. Switch stdout to binary
mode for this case, at the same place where we do it for non-text output
formats.

Report and patch by Kuntal Ghosh, tested by Ashutosh Sharma and Neha
Sharma. Back-patch to all supported branches.

Discussion: https://postgr.es/m/CAGz5QCJPvbBjXAmJuGx1B_41yVCetAJhp7rtaDf7XQGWuB1GSw@mail.gmail.com

Branch
------
REL9_5_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/4fc274dd8c1d9b5a3ae7196b726c082a39a66384

Modified Files
--------------
src/bin/pg_dump/pg_backup_archiver.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2017-06-19 19:33:59 pgsql: Avoid regressions in foreign-key-based selectivity estimates.
Previous Message Andres Freund 2017-06-19 02:30:15 pgsql: Fix leaking of small spilled subtransactions during logical deco