From: | Andres Freund <andres(at)anarazel(dot)de> |
---|---|
To: | pgsql-committers(at)postgresql(dot)org |
Subject: | pgsql: Fix leaking of small spilled subtransactions during logical deco |
Date: | 2017-06-19 02:30:15 |
Message-ID: | E1dMmSF-0000KP-0n@gemulon.postgresql.org |
Views: | Whole Thread | Raw Message | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Fix leaking of small spilled subtransactions during logical decoding.
When, during logical decoding, a transaction gets too big, it's
contents get spilled to disk. Not just the top-transaction gets
spilled, but *also* all of its subtransactions, even if they're not
that large themselves. Unfortunately we didn't clean up
such small spilled subtransactions from disk.
Fix that, by keeping better track of whether a transaction has been
spilled to disk.
Author: Andres Freund
Reported-By: Dmitriy Sarafannikov, Fabrízio de Royes Mello
Discussion:
https://postgr.es/m/1457621358.355011041@f382.i.mail.ru
https://postgr.es/m/CAFcNs+qNMhNYii4nxpO6gqsndiyxNDYV0S=JNq0v_sEE+9PHXg@mail.gmail.com
Backpatch: 9.4-, where logical decoding was introduced
Branch
------
REL9_4_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/a27c566c77f86ac61633da05a284c1cc4a8fa389
Modified Files
--------------
src/backend/replication/logical/reorderbuffer.c | 7 ++++---
src/include/replication/reorderbuffer.h | 9 +++++++++
2 files changed, 13 insertions(+), 3 deletions(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2017-06-19 15:03:51 | pgsql: On Windows, make pg_dump use binary mode for compressed plain te |
Previous Message | Andres Freund | 2017-06-19 02:30:13 | pgsql: Fix leaking of small spilled subtransactions during logical deco |