pgsql: Fix cursor_to_xml in tableforest false mode

From: Peter Eisentraut <peter_e(at)gmx(dot)net>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Fix cursor_to_xml in tableforest false mode
Date: 2017-05-05 02:45:07
Message-ID: E1d6TEx-0000KA-0U@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Fix cursor_to_xml in tableforest false mode

It only produced <row> elements but no wrapping <table> element.

By contrast, cursor_to_xmlschema produced a schema that is now correct
but did not previously match the XML data produced by cursor_to_xml.

In passing, also fix a minor misunderstanding about moving cursors in
the tests related to this.

Reported-by: filip(at)jirsak(dot)org
Based-on-patch-by: Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com>

Branch
------
REL9_5_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/9750a9583aacefbde15d9ed4ebfed84f1fb3aae8

Modified Files
--------------
src/backend/utils/adt/xml.c | 13 +++++++
src/test/regress/expected/xmlmap.out | 64 +++++++++++++++++++++++++++-------
src/test/regress/expected/xmlmap_1.out | 6 +++-
src/test/regress/sql/xmlmap.sql | 3 +-
4 files changed, 71 insertions(+), 15 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Amit Kapila 2017-05-05 05:34:14 Re: Change GetLastImportantRecPtr's definition? (wasSkip checkpoints, archiving on idle systems.)
Previous Message Stephen Frost 2017-05-05 02:18:54 pgsql: Change the way pg_dump retrieves partitioning info