pgsql: Ensure commands in extension scripts see the results of precedin

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Ensure commands in extension scripts see the results of precedin
Date: 2017-05-02 22:06:17
Message-ID: E1d5fw1-0000G0-UN@gemulon.postgresql.org
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Ensure commands in extension scripts see the results of preceding DDL.

Due to a missing CommandCounterIncrement() call, parsing of a non-utility
command in an extension script would not see the effects of the immediately
preceding DDL command, unless that command's execution ends with
CommandCounterIncrement() internally ... which some do but many don't.
Report by Philippe Beaudoin, diagnosis by Julien Rouhaud.

Rather remarkably, this bug has evaded detection since extensions were
invented, so back-patch to all supported branches.

Discussion: https://postgr.es/m/2cf7941e-4e41-7714-3de8-37b1a8f74dff@free.fr

Branch
------
REL9_6_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/d56b8b41b32b3f5c576d6fc2b2c9af3ae4b55511

Modified Files
--------------
src/backend/commands/extension.c | 3 +++
src/test/modules/test_extensions/test_ext3--1.0.sql | 6 ++++++
2 files changed, 9 insertions(+)

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2017-05-03 00:41:46 pgsql: Remove create_singleton_array(), hard-coding the case in its sol
Previous Message Alvaro Herrera 2017-05-02 21:51:24 pgsql: extstats: change output functions to emit valid JSON