| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | pgsql-committers(at)postgresql(dot)org |
| Subject: | pgsql: Fix possible null pointer dereference or invalid warning message |
| Date: | 2017-04-30 16:21:07 |
| Message-ID: | E1d4rat-000716-Ei@gemulon.postgresql.org |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Fix possible null pointer dereference or invalid warning message.
Thinko in commit de4389712: this warning message references the wrong
"LogicalRepWorker *" variable. This would often result in a core dump,
but if it didn't, the message would show the wrong subscription OID.
In passing, adjust the message text to format a subscription OID
similarly to how that's done elsewhere in the function; and fix
grammatical issues in some nearby messages.
Per Coverity testing.
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/12d11432b4db8a2ae665287e05f0f6868d35545e
Modified Files
--------------
src/backend/replication/logical/launcher.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2017-04-30 19:14:40 | pgsql: Sync our copy of the timezone library with IANA release tzcode20 |
| Previous Message | Tom Lane | 2017-04-30 00:15:40 | pgsql: Micro-optimize some slower queries in the opr_sanity regression |