pgsql: Repair crash with unsortable data in grouping sets.

From: Andrew Gierth <rhodiumtoad(at)postgresql(dot)org>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Repair crash with unsortable data in grouping sets.
Date: 2017-04-24 07:03:20
Message-ID: E1d2Y1o-0002xY-2K@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Repair crash with unsortable data in grouping sets.

Previously the code would generate incorrect results, assertion
failures, or crashes if given unsortable (but hashable) columns in
grouping sets. Handle by throwing an error instead.

Report and patch by Pavan Deolasee (though I changed the error
wording slightly); regression test by me.

(This affects 9.5 only since the planner was refactored in 9.6.)

Branch
------
REL9_5_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/7be3678a8cfb55dcfca90fa586485f835ab912a5

Modified Files
--------------
src/backend/optimizer/plan/planner.c | 5 +++++
src/test/regress/expected/groupingsets.out | 7 +++++++
src/test/regress/sql/groupingsets.sql | 4 ++++
3 files changed, 16 insertions(+)

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2017-04-24 15:15:21 pgsql: Code review for commands/statscmds.c.
Previous Message Tom Lane 2017-04-24 02:53:15 Re: [COMMITTERS] pgsql: Replication lag tracking for walsenders