pgsql: Code review for c94e6942cefe7d20c5feed856e27f672734b1e2b.

Code review for c94e6942cefe7d20c5feed856e27f672734b1e2b.

validateCheckConstraint() shouldn't try to access the storage for
a partitioned table, because it no longer has any. Creating a
_RETURN table on a partitioned table shouldn't be allowed, both
because there's no value in it and because trying to do so would
involve a validation scan against its nonexistent storage.

Amit Langote, reviewed by Tom Lane. Regression test outputs
updated to pass by me.

Discussion: http://postgr.es/m/e5c3cbd3-1551-d6f8-c9e2-51777d632fd2@lab.ntt.co.jp

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/1d5fede4a900d135745c1fa5a70dcfe0b3359e3d

Modified Files
--------------
src/backend/commands/tablecmds.c | 8 ++++++--
src/backend/rewrite/rewriteDefine.c | 6 ++++++
src/test/regress/expected/alter_table.out | 6 ++++++
src/test/regress/expected/rules.out | 5 +++++
src/test/regress/sql/alter_table.sql | 7 +++++++
src/test/regress/sql/rules.sql | 5 +++++
6 files changed, 35 insertions(+), 2 deletions(-)