pgsql: Fix logical replication between different encodings

Fix logical replication between different encodings

When sending a tuple attribute, the previous coding erroneously sent the
length byte before encoding conversion, which would lead to protocol
failures on the receiving side if the length did not match the following
string.

To fix that, use pq_sendcountedtext() for sending tuple attributes,
which takes care of all of that internally. To match the API of
pq_sendcountedtext(), send even text values without a trailing zero byte
and have the receiving end put it in place instead. This matches how
the standard FE/BE protocol behaves.

Reported-by: Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp>

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/6f1b9aaae35bfabe2654a8e44ce226c91e7d8bd9

Modified Files
--------------
doc/src/sgml/protocol.sgml | 7 +++--
src/backend/replication/logical/proto.c | 10 +++----
src/test/subscription/t/005_encoding.pl | 46 +++++++++++++++++++++++++++++++++
3 files changed, 55 insertions(+), 8 deletions(-)