pgsql: Remove dead code and fix comments in fast-path function handling

From: Heikki Linnakangas <heikki(dot)linnakangas(at)iki(dot)fi>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Remove dead code and fix comments in fast-path function handling
Date: 2017-04-06 06:12:01
Message-ID: E1cw0eH-00012G-21@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Remove dead code and fix comments in fast-path function handling.

HandleFunctionRequest() is no longer responsible for reading the protocol
message from the client, since commit 2b3a8b20c2. Fix the outdated
comments.

HandleFunctionRequest() now always returns 0, because the code that used
to return EOF was moved in 2b3a8b20c2. Therefore, the caller no longer
needs to check the return value.

Reported by Andres Freund. Backpatch to all supported versions, even though
this doesn't have any user-visible effect, to make backporting future
patches in this area easier.

Discussion: https://www.postgresql.org/message-id/20170405010525.rt5azbya5fkbhvrx@alap3.anarazel.de

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/fd01983594b7d2119653428e3b532578008c7065

Modified Files
--------------
src/backend/tcop/fastpath.c | 22 +++++-----------------
src/backend/tcop/postgres.c | 14 +-------------
src/include/tcop/fastpath.h | 2 +-
3 files changed, 7 insertions(+), 31 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message David Rowley 2017-04-06 06:59:35 Re: [COMMITTERS] pgsql: Collect and use multi-column dependency stats
Previous Message Kyotaro HORIGUCHI 2017-04-06 06:03:16 Re: [COMMITTERS] pgsql: Collect and use multi-column dependency stats