pgsql: Fix backup canceling

From: Teodor Sigaev <teodor(at)sigaev(dot)ru>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Fix backup canceling
Date: 2017-03-24 10:54:01
Message-ID: E1crMr3-00048B-Lj@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Fix backup canceling

Assert-enabled build crashes but without asserts it works by wrong way:
it may not reset forcing full page write and preventing from starting
exclusive backup with the same name as cancelled.
Patch replaces pair of booleans
nonexclusive_backup_running/exclusive_backup_running to single enum to
correctly describe backup state.

Backpatch to 9.6 where bug was introduced

Reported-by: David Steele
Authors: Michael Paquier, David Steele
Reviewed-by: Anastasia Lubennikova

https://commitfest.postgresql.org/13/1068/

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/78874531baf99769468dedfff19aa7e2068bc5e5

Modified Files
--------------
src/backend/access/transam/xlog.c | 22 ++++++++++++++++++++++
src/backend/access/transam/xlogfuncs.c | 25 ++++++++++---------------
src/include/access/xlog.h | 21 ++++++++++++++++++++-
3 files changed, 52 insertions(+), 16 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Teodor Sigaev 2017-03-24 10:55:45 pgsql: Fix backup canceling
Previous Message Heikki Linnakangas 2017-03-24 10:44:24 Re: Re: [COMMITTERS] pgsql: Fix and simplify check for whether we're running as Windows serv