pgsql: amcheck: Harden tests against concurrent autovacuums.

From: Andres Freund <andres(at)anarazel(dot)de>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: amcheck: Harden tests against concurrent autovacuums.
Date: 2017-03-14 20:09:12
Message-ID: E1cnskq-0002yz-UN@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

amcheck: Harden tests against concurrent autovacuums.

The previous coding of the test was vulnerable against autovacuum
triggering work on one of the tables in check_btree.sql.

For the purpose of the test it's entirely sufficient to check for
locks taken by the current process, so add an appropriate restriction.
While touching the test, expand it to also check for locks on the
underlying relations, rather than just the indexes.

Reported-By: Tom Lane
Discussion: https://postgr.es/m/30354.1489434301@sss.pgh.pa.us

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/71504026556fc1494c9a7045aad9645f7d9e4cdf

Modified Files
--------------
contrib/amcheck/expected/check_btree.out | 4 +++-
contrib/amcheck/sql/check_btree.sql | 4 +++-
2 files changed, 6 insertions(+), 2 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Andres Freund 2017-03-14 20:09:17 Re: [COMMITTERS] pgsql: Add amcheck extension to contrib.
Previous Message Robert Haas 2017-03-14 19:02:01 pgsql: hash: Support WAL consistency checking.