pgsql: Remove some bogus logic from create_gather_merge_plan.

From: Robert Haas <rhaas(at)postgresql(dot)org>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Remove some bogus logic from create_gather_merge_plan.
Date: 2017-03-14 11:49:51
Message-ID: E1cnkxb-0001ng-MT@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Remove some bogus logic from create_gather_merge_plan.

This logic was adapated from create_merge_append_plan, but the two
cases aren't really analogous, because create_merge_append_plan is not
projection-capable and must therefore have a tlist identical to that
of the underlying paths. Overwriting the tlist of Gather Merge with
whatever the underlying plan happens to produce is no good at all.

Patch by me, reviewed by Rushabh Lathia, who also reported the issue
and made an initial attempt at a fix.

Discussion: http://postgr.es/m/CA+Tgmob_-oHEOBfT9S25bjqokdqv8e8xEmh9zOY+3MPr_LmuhA@mail.gmail.com

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/bce352fb46196340749cf907f3168b5f63969329

Modified Files
--------------
src/backend/optimizer/plan/createplan.c | 48 ++++++++-------------------------
1 file changed, 11 insertions(+), 37 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Robert Haas 2017-03-14 11:54:44 pgsql: Update overlooked comment for Gather Merge.
Previous Message Stephen Frost 2017-03-14 11:37:01 Re: [COMMITTERS] pgsql: Improve postmaster's logging of listen socket creation.