From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | pgsql-committers(at)postgresql(dot)org |
Subject: | pgsql: Blind try to fix portability issue in commit 8f93bd851 et al. |
Date: | 2017-02-09 20:50:27 |
Message-ID: | E1cbvff-0004Rt-52@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Blind try to fix portability issue in commit 8f93bd851 et al.
The S/390 members of the buildfarm are showing failures indicating
that they're having trouble with the rint() calls I added yesterday.
There's no good reason for that, and I wonder if it is a compiler bug
similar to the one we worked around in d9476b838. Try to fix it using
the same method as before, namely to store the result of rint() back
into a "double" variable rather than immediately converting to int64.
(This isn't entirely waving a dead chicken, since on machines with
wider-than-double float registers, the extra store forces a width
conversion. I don't know if S/390 is like that, but it seems worth
trying.)
In passing, merge duplicate ereport() calls in float8_timestamptz().
Per buildfarm.
Branch
------
master
Details
-------
http://git.postgresql.org/pg/commitdiff/5d2adf0f81a2e4ca4f101b19b1efea147b462301
Modified Files
--------------
src/backend/utils/adt/timestamp.c | 14 ++++++--------
1 file changed, 6 insertions(+), 8 deletions(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Robert Haas | 2017-02-09 21:23:57 | pgsql: Rename user-facing tools with "xlog" in the name to say "wal". |
Previous Message | Robert Haas | 2017-02-09 20:36:04 | pgsql: Remove all references to "xlog" from SQL-callable functions in p |