pgsql: pageinspect: Try to fix some bugs in previous commit.

From: Robert Haas <rhaas(at)postgresql(dot)org>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: pageinspect: Try to fix some bugs in previous commit.
Date: 2017-02-03 03:32:43
Message-ID: E1cZUc7-0001gM-ES@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

pageinspect: Try to fix some bugs in previous commit.

Commit 08bf6e529587e1e9075d013d859af2649c32a511 seems not to have
used the correct *GetDatum and PG_GETARG_* macros for the SQL types
in some cases, and some of the SQL types seem to have been poorly
chosen, too. Try to fix it. I'm not sure if this is the reason
why the buildfarm is currently unhappy with this code, but it
seems like a good place to start.

Buildfarm unhappiness reported by Tom Lane.

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/ed807fda6d5102537daa5d725e716555cbc49f44

Modified Files
--------------
contrib/pageinspect/hashfuncs.c | 28 +++++++++++++--------------
contrib/pageinspect/pageinspect--1.5--1.6.sql | 10 +++++-----
2 files changed, 19 insertions(+), 19 deletions(-)

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2017-02-03 03:40:51 Re: pgsql: pageinspect: Try to fix some bugs in previous commit.
Previous Message Tom Lane 2017-02-03 02:27:16 Re: pgsql: pageinspect: Support hash indexes.

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2017-02-03 03:40:51 Re: pgsql: pageinspect: Try to fix some bugs in previous commit.
Previous Message Kyotaro HORIGUCHI 2017-02-03 03:16:49 Re: [BUGS] Bug in Physical Replication Slots (at least 9.5)?