pgsql: Fix Assert failure induced by commit 215b43cdc.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Fix Assert failure induced by commit 215b43cdc.
Date: 2017-01-19 23:21:10
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-committers

Fix Assert failure induced by commit 215b43cdc.

I'd somehow talked myself into believing that set_append_rel_size
doesn't need to worry about getting back an AND clause when it applies
eval_const_expressions to the result of adjust_appendrel_attrs (that is,
transposing the appendrel parent's restriction clauses for one child).
But that is nonsense, and Andreas Seltenreich's fuzz tester soon
turned up a counterexample. Put back the make_ands_implicit step
that was there before, and add a regression test covering the case.




Modified Files
src/backend/optimizer/path/allpaths.c | 43 ++++++++++++++++++++---------------
src/test/regress/expected/union.out | 30 ++++++++++++++++++++++++
src/test/regress/sql/union.sql | 13 +++++++++++
3 files changed, 68 insertions(+), 18 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2017-01-20 00:52:18 pgsql: Avoid core dump for empty prepared statement in an aborted trans
Previous Message Andres Freund 2017-01-19 22:42:25 pgsql: Fix platform dependant regression output triggered by 69f4b9c85f