pgsql: Improve dblink error message when remote does not provide it

From: Joe Conway <mail(at)joeconway(dot)com>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Improve dblink error message when remote does not provide it
Date: 2016-12-21 23:53:12
Message-ID: E1cJqh6-0007Kp-I9@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Improve dblink error message when remote does not provide it

When dblink or postgres_fdw detects an error on the remote side of the
connection, it will try to construct a local error message as best it
can using libpq's PQresultErrorField(). When no primary message is
available, it was bailing out with an unhelpful "unknown error". Make
that message better and more style guide compliant. Per discussion
on hackers.

Backpatch to 9.2 except postgres_fdw which didn't exist before 9.3.

Discussion: https://postgr.es/m/19872.1482338965%40sss.pgh.pa.us

Branch
------
REL9_2_STABLE

Details
-------
http://git.postgresql.org/pg/commitdiff/fb0ab06dc4f4c90b85c220418445f4c8f15a59ca

Modified Files
--------------
contrib/dblink/dblink.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Amit Langote 2016-12-22 01:00:18 Re: [COMMITTERS] pgsql: Implement table partitioning.
Previous Message Joe Conway 2016-12-21 23:53:09 pgsql: Improve dblink error message when remote does not provide it