From: | Fujii Masao <fujii(at)postgresql(dot)org> |
---|---|
To: | pgsql-committers(at)postgresql(dot)org |
Subject: | pgsql: Forbid invalid combination of options in pg_basebackup. |
Date: | 2016-12-21 11:27:53 |
Message-ID: | E1cJf3p-0002Nu-QB@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Forbid invalid combination of options in pg_basebackup.
Commit 56c7d8d4552180fd66fe48423bb2a9bb767c2d87 allowed pg_basebackup
to stream WAL in tar mode. But there is the restriction that WAL
streaming in tar mode works only when the value - (dash) is not
specified as output directory. This means that the combination of
three options "-D -", "-F t" and "-X stream" is invalid. However,
previously, even when those options were specified at the same time,
pg_basebackup background process unexpectedly started streaming WAL.
And then it exited with an error.
This commit changes pg_basebackup so that it errors out on such
invalid combination of options at the beginning.
Reviewed by Magnus Hagander, and patch by me.
Branch
------
master
Details
-------
http://git.postgresql.org/pg/commitdiff/ecbdc4c555f43b1ac284c734752b00c2ea6f277b
Modified Files
--------------
src/bin/pg_basebackup/pg_basebackup.c | 10 ++++++++++
1 file changed, 10 insertions(+)
From | Date | Subject | |
---|---|---|---|
Next Message | Robert Haas | 2016-12-21 12:54:51 | Re: [COMMITTERS] pgsql: Simplify LWLock tranche machinery by removing array_base/array_s |
Previous Message | Pavel Stehule | 2016-12-21 07:14:12 | Re: pgsql: Simplify LWLock tranche machinery by removing array_base/array_s |