pgsql: Fix pg_dump to work against pre-9.0 servers again.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Fix pg_dump to work against pre-9.0 servers again.
Date: 2016-10-07 13:51:35
Message-ID: E1bsVYl-0007Oc-Np@gemulon.postgresql.org
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Fix pg_dump to work against pre-9.0 servers again.

getBlobs' queries for pre-9.0 servers were broken in two ways:
the 7.x/8.x query uses DISTINCT so it can't have unspecified-type
NULLs in the target list, and both that query and the 7.0 one
failed to provide the correct output column labels, so that the
subsequent code to extract data from the PGresult would fail.

Back-patch to 9.6 where the breakage was introduced (by commit 23f34fa4b).

Amit Langote and Tom Lane

Discussion: <0a3e7a0e-37bd-8427-29bd-958135862f0a(at)lab(dot)ntt(dot)co(dot)jp>

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/4806f26f9e4273888cbf85f42b3bdc5e9d950ba6

Modified Files
--------------
src/bin/pg_dump/pg_dump.c | 17 +++++++++--------
1 file changed, 9 insertions(+), 8 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2016-10-07 15:27:43 pgsql: Fix python shlib probe for Cygwin.
Previous Message Heikki Linnakangas 2016-10-07 11:39:11 pgsql: Don't allow both --source-server and --source-target args to pg_