From: | Dave Page <dpage(at)pgadmin(dot)org> |
---|---|
To: | pgadmin-hackers(at)postgresql(dot)org |
Subject: | pgAdmin 4 commit: Don't show Upload File icon unless it is in capabilit |
Date: | 2016-10-07 11:31:41 |
Message-ID: | E1bsTNN-0003gZ-Jg@gothos.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
Don't show Upload File icon unless it is in capabilities list [Storage Manager]. Fixes #1739
Issue:
When clicked on upload icon while saving a file prompt user to leave page. It is because the icon is a button and its type is set to submit which makes it to prompt, instead it should be 'button'
Storage Manager's menu items depends on capabilities list set by the module using it. If capabilities doesn't have 'upload' in it, It won't work. Upload button is bound to click event only when it is in capabilities.
Solution:
As upload button is being added only when it is in capabilities, so upload button html is removed from html file. It will not shown on UI untill it is in capabilities list.
Branch
------
master
Details
-------
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=3963272523c1061acfbaa78243b77dde5a063d08
Author: Surinder Kumar <surinder(dot)kumar(at)enterprisedb(dot)com>
Modified Files
--------------
web/pgadmin/misc/file_manager/templates/file_manager/index.html | 2 --
web/pgadmin/misc/file_manager/templates/file_manager/js/utility.js | 2 +-
2 files changed, 1 insertion(+), 3 deletions(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Dave Page | 2016-10-07 11:31:48 | Re: [pgAdmin4][Patch]: RM1739 - Don't show Upload File icon unless it is not in capabilities [Storage Manager] |
Previous Message | Khushboo Vashi | 2016-10-07 11:28:11 | [pgAdmin4][Patch]: RM 1785 - PPAS Servers are consider to be PostgreSQL until after the first disconnect/reconnect |