pgsql: Convert PageAddItem into a macro to save a few cycles.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Convert PageAddItem into a macro to save a few cycles.
Date: 2016-09-09 22:17:13
Message-ID: E1biU6j-0003Zp-UH@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Convert PageAddItem into a macro to save a few cycles.

Nowadays this is just a backwards-compatibility wrapper around
PageAddItemExtended, so let's avoid the extra level of function call.
In addition, because pretty much all callers are passing constants
for the two bool arguments, compilers will be able to constant-fold
the conversion to a flags bitmask.

Discussion: <552(dot)1473445163(at)sss(dot)pgh(dot)pa(dot)us>

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/1a4be103a523db8d47b464463ba175cc664442b2

Modified Files
--------------
src/backend/storage/page/bufpage.c | 20 --------------------
src/include/storage/bufpage.h | 7 +++++--
2 files changed, 5 insertions(+), 22 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2016-09-09 23:01:08 pgsql: Rewrite PageIndexDeleteNoCompact into a form that only deletes 1
Previous Message Tom Lane 2016-09-09 22:02:50 pgsql: Invent PageIndexTupleOverwrite, and teach BRIN and GiST to use i