pgsql: Fix hard to hit race condition in heapam's tuple locking code.

From: Andres Freund <andres(at)anarazel(dot)de>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Fix hard to hit race condition in heapam's tuple locking code.
Date: 2016-08-05 03:10:35
Message-ID: E1bVVWt-0001Ia-2W@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Fix hard to hit race condition in heapam's tuple locking code.

As mentioned in its commit message, eca0f1db left open a race condition,
where a page could be marked all-visible, after the code checked
PageIsAllVisible() to pin the VM, but before the page is locked. Plug
that hole.

Reviewed-By: Robert Haas, Andres Freund
Author: Amit Kapila
Discussion: CAEepm=3fWAbWryVW9swHyLTY4sXVf0xbLvXqOwUoDiNCx9mBjQ(at)mail(dot)gmail(dot)com
Backpatch: -

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/e7caacf733f3ee77a555aa715ab6fbf4434e6b52

Modified Files
--------------
src/backend/access/heap/heapam.c | 44 ++++++++++++++++++++++++++++++++++------
1 file changed, 38 insertions(+), 6 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Robert Haas 2016-08-05 03:59:06 Re: [COMMITTERS] pgsql: Prevent "snapshot too old" from trying to return pruned TOAST tu
Previous Message Robert Haas 2016-08-05 02:58:28 Re: pgsql: Prevent "snapshot too old" from trying to return pruned TOAST tu