| From: | Robert Haas <rhaas(at)postgresql(dot)org> |
|---|---|
| To: | pgsql-committers(at)postgresql(dot)org |
| Subject: | pgsql: postgres_fdw: Fix incorrect NULL handling in join pushdown. |
| Date: | 2016-06-24 19:14:41 |
| Message-ID: | E1bGWYr-0003cQ-Ck@gemulon.postgresql.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
postgres_fdw: Fix incorrect NULL handling in join pushdown.
something.* IS NOT NULL means that every attribute of the row is not
NULL, not that the row itself is non-NULL (e.g. because it's coming
from below an outer join. Use (somevar.*)::pg_catalog.text IS NOT
NULL instead.
Ashutosh Bapat, per a report by Rushabh Lathia. Reviewed by
Amit Langote and Etsuro Fujita. Schema-qualification added by me.
Branch
------
master
Details
-------
http://git.postgresql.org/pg/commitdiff/9e9c38e15947f4f3ed478f8b70e74b55e31fe950
Modified Files
--------------
contrib/postgres_fdw/deparse.c | 8 ++--
contrib/postgres_fdw/expected/postgres_fdw.out | 62 +++++++++++++++++---------
contrib/postgres_fdw/sql/postgres_fdw.sql | 5 +++
3 files changed, 50 insertions(+), 25 deletions(-)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2016-06-24 20:57:47 | pgsql: Fix building of large (bigger than shared_buffers) hash indexes. |
| Previous Message | Robert Haas | 2016-06-24 18:38:30 | pgsql: postgres_fdw: Remove useless return statement. |