pgsql: pg_dump only selected components of ACCESS METHODs

From: Stephen Frost <sfrost(at)snowman(dot)net>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: pg_dump only selected components of ACCESS METHODs
Date: 2016-06-07 13:56:07
Message-ID: E1bAHUF-00043s-UW@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

pg_dump only selected components of ACCESS METHODs

dumpAccessMethod() didn't get the memo that we now have a bitfield for
the components which should be dumped instead of a simple boolean.

Correct that by checking if the relevant bit is set for each component
being dumped out (and not dumping it out if it isn't set).

This corrects an issue where CREATE ACCESS METHOD commands were being
included in non-binary-upgrades when an extension included an access
method (as the bloom extensions does).

Also add a regression test to make sure that we only dump out the
ACCESS METHOD commands, when they are part of an extension, when doing
a binary upgrade.

Pointed out by Thom Brown.

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/562f06f3f0da92e397a2f05e1b9b5bfbde336fb2

Modified Files
--------------
src/bin/pg_dump/pg_dump.c | 26 ++++++++++++----------
src/test/modules/test_pg_dump/t/001_base.pl | 20 +++++++++++++++++
.../modules/test_pg_dump/test_pg_dump--1.0.sql | 2 ++
3 files changed, 36 insertions(+), 12 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Simon Riggs 2016-06-07 14:21:54 pgsql: Fix simple typo in monitoring docs
Previous Message Peter Eisentraut 2016-06-07 13:39:52 pgsql: PL/Python: Move ereport wrapper test cases to separate file