pgsql: Do not DROP default roles in pg_dumpall -c

From: Stephen Frost <sfrost(at)snowman(dot)net>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Do not DROP default roles in pg_dumpall -c
Date: 2016-05-25 03:32:01
Message-ID: E1b5PY9-0004Hz-Q8@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Do not DROP default roles in pg_dumpall -c

When pulling the list of roles to drop, exclude roles whose names
begin with "pg_" (as we do when we are dumping the roles out to
recreate them).

Also add regression tests to cover pg_dumpall -c and this specific
issue.

Noticed by Rushabh Lathia. Patch by me.

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/018eb027f181234be7a580e9502c40ac5ad04f77

Modified Files
--------------
src/bin/pg_dump/pg_dumpall.c | 8 +++-
src/bin/pg_dump/t/002_pg_dump.pl | 87 +++++++++++++++++++++++++++++++++++++++-
2 files changed, 93 insertions(+), 2 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Kevin Grittner 2016-05-25 16:21:38 pgsql: Update doc text to reflect new column in MVCC phenomena table.
Previous Message Tom Lane 2016-05-25 02:49:42 pgsql: Mark wal_level as PGDLLIMPORT.