pgsql: Qualify table usage in dumpTable() and use regclass

From: Stephen Frost <sfrost(at)snowman(dot)net>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Qualify table usage in dumpTable() and use regclass
Date: 2016-05-25 00:10:22
Message-ID: E1b5MP0-0008CL-TA@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Qualify table usage in dumpTable() and use regclass

All of the other tables used in the query in dumpTable(), which is
collecting column-level ACLs, are qualified, so we should be qualifying
the pg_init_privs, the related sub-select against pg_class and the
other queries added by the pg_dump catalog ACLs work.

Also, use ::regclass (or ::pg_catalog.regclass, where appropriate)
instead of using a poorly constructed query to get the OID for various
catalog tables.

Issues identified by Noah and Alvaro, patch by me.

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/2e8b4bf80473d0e4a4254b417424e79195a9ce6a

Modified Files
--------------
src/bin/pg_dump/dumputils.c | 24 +++++------
src/bin/pg_dump/pg_dump.c | 67 +++++++++++++++--------------
src/test/modules/test_pg_dump/t/001_base.pl | 8 ++--
3 files changed, 50 insertions(+), 49 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2016-05-25 01:05:03 pgsql: Fix contrib/bloom to work for unlogged indexes.
Previous Message Andres Freund 2016-05-24 21:56:16 Re: Re: [COMMITTERS] pgsql: Avoid extra locks in GetSnapshotData if old_snapshot_threshold <