pgsql: Rename pgbench min/max to least/greatest, and fix handling of do

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Rename pgbench min/max to least/greatest, and fix handling of do
Date: 2016-05-05 18:51:13
Message-ID: E1ayOMj-0003ay-8e@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Rename pgbench min/max to least/greatest, and fix handling of double args.

These functions behave like the backend's least/greatest functions,
not like min/max, so the originally-chosen names invite confusion.
Per discussion, rename to least/greatest.

I also took it upon myself to make them return double if any input is
double. The previous behavior of silently coercing all inputs to int
surely does not meet the principle of least astonishment.

Copy-edit some of the other new functions' documentation, too.

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/7a622b2731db5d0f6db8a3d0af88177f96d1cb2e

Modified Files
--------------
doc/src/sgml/ref/pgbench.sgml | 25 +++++++++--------
src/bin/pgbench/exprparse.y | 8 +++---
src/bin/pgbench/pgbench.c | 64 ++++++++++++++++++++++++++++++++-----------
src/bin/pgbench/pgbench.h | 4 +--
4 files changed, 67 insertions(+), 34 deletions(-)

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2016-05-05 22:52:37 pgsql: Small 9.6 release note improvements.
Previous Message Tom Lane 2016-05-05 17:28:12 pgsql: First-draft release notes for Postgres 9.6.