pgsql: Improve regression tests for degree-based trigonometric function

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Improve regression tests for degree-based trigonometric function
Date: 2016-04-19 20:47:27
Message-ID: E1ascYR-0004no-7M@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Improve regression tests for degree-based trigonometric functions.

Print the actual value of each function result that's expected to be exact,
rather than merely emitting a NULL if it's not right. Although we print
these with extra_float_digits = 3, we should not trust that the platform
will produce a result visibly different from the expected value if it's off
only in the last place; hence, also include comparisons against the exact
values as before. This is a bit bulkier and uglier than the previous
printout, but it will provide more information and be easier to interpret
if there's a test failure.

Discussion: <18241(dot)1461073100(at)sss(dot)pgh(dot)pa(dot)us>

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/4db0d2d2fe935e086dfd26c00f707dab298b443c

Modified Files
--------------
.../expected/float8-exp-three-digits-win32.out | 155 ++++++++++++---------
src/test/regress/expected/float8-small-is-zero.out | 155 ++++++++++++---------
.../regress/expected/float8-small-is-zero_1.out | 155 ++++++++++++---------
src/test/regress/expected/float8.out | 155 ++++++++++++---------
src/test/regress/sql/float8.sql | 48 +++++--
5 files changed, 399 insertions(+), 269 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2016-04-19 20:48:28 Re: [COMMITTERS] pgsql: Add trigonometric functions that work in degrees.
Previous Message Dean Rasheed 2016-04-19 15:33:04 Re: [COMMITTERS] pgsql: Add trigonometric functions that work in degrees.