pgsql: In generic WAL application and replay, ensure page "hole" is alw

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: In generic WAL application and replay, ensure page "hole" is alw
Date: 2016-04-12 15:14:13
Message-ID: E1aq017-0000DZ-Dk@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

In generic WAL application and replay, ensure page "hole" is always zero.

The previous coding could allow the contents of the "hole" between pd_lower
and pd_upper to diverge during replay from what it had been when the update
was originally applied. This would pose a problem if checksums were in
use, and in any case would complicate forensic comparisons between master
and slave servers. So force the "hole" to contain zeroes, both at initial
application of a generically-logged action, and at replay.

Alexander Korotkov, adjusted slightly by me

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/bdf7db81921deb99fd9d489cbcc635906c89e215

Modified Files
--------------
src/backend/access/transam/generic_xlog.c | 40 ++++++++++++++++++++++++++++---
1 file changed, 37 insertions(+), 3 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2016-04-12 15:42:12 pgsql: Improve API of GenericXLogRegister().
Previous Message Teodor Sigaev 2016-04-12 15:08:55 pgsql: Add page id to bloom index