pgsql: Fix poorly thought-through code from commit 5c3c3cd0a3046339.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Fix poorly thought-through code from commit 5c3c3cd0a3046339.
Date: 2016-04-11 04:28:52
Message-ID: E1apTT2-0000kT-U8@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Fix poorly thought-through code from commit 5c3c3cd0a3046339.

It's not entirely clear to me whether PyString_AsString can return
null (looks like the answer might vary between Python 2 and 3).
But in any case, this code's attempt to cope with the possibility
was quite broken, because pstrdup() neither allows a null argument
nor ever returns a null.

Moreover, the code below this point assumes that "message" is a
palloc'd string, which would not be the case for a dgettext result.

Fix both problems by doing the pstrdup step separately.

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/f73b2bbbdcb387aa90ff619fe03d1924ed82b868

Modified Files
--------------
src/pl/plpython/plpy_plpymodule.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Fujii Masao 2016-04-11 06:53:28 pgsql: Use ereport(ERROR) instead of Assert() to emit syncrep_parser er
Previous Message Andres Freund 2016-04-11 04:01:01 Re: [COMMITTERS] pgsql: Move each SLRU's lwlocks to a separate tranche.