From: | Andres Freund <andres(at)anarazel(dot)de> |
---|---|
To: | pgsql-committers(at)postgresql(dot)org |
Subject: | pgsql: Further improvements to c8f621c43. |
Date: | 2016-03-07 22:26:23 |
Message-ID: | E1ad3bb-0001JG-A4@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Further improvements to c8f621c43.
Coverity and inspection for the issue addressed in fd45d16f found some
questionable code.
Specifically coverity noticed that the wrong length was added in
ReorderBufferSerializeChange() - without immediate negative consequences
as the variable isn't used afterwards. During code-review and testing I
noticed that a bit of space was wasted when allocating tuple bufs in
several places. Thirdly, the debug memset()s in
ReorderBufferGetTupleBuf() reduce the error checking valgrind can do.
Backpatch: 9.4, like c8f621c43.
Branch
------
REL9_4_STABLE
Details
-------
http://git.postgresql.org/pg/commitdiff/e3e84fd35838a43feef94ea78534713d745e9a08
Modified Files
--------------
src/backend/replication/logical/decode.c | 24 +++++++++++++++---------
src/backend/replication/logical/reorderbuffer.c | 3 +++
2 files changed, 18 insertions(+), 9 deletions(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Joe Conway | 2016-03-07 23:16:07 | pgsql: Make get_controlfile() error logging consistent with src/common |
Previous Message | Andres Freund | 2016-03-07 22:26:22 | pgsql: Further improvements to c8f621c43. |