pgsql: Fix broken definition for function name in pgbench's exprscan.l.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Fix broken definition for function name in pgbench's exprscan.l.
Date: 2016-03-07 02:04:30
Message-ID: E1ackX8-0007H5-Ih@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Fix broken definition for function name in pgbench's exprscan.l.

As written, this would accept e.g. 123e9 as a function name. Aside
from being mildly astonishing, that would come back to haunt us if
we ever try to add float constants to the expression syntax. Insist
that function names start with letters (or at least non-digits).

In passing reset yyline as well as yycol when starting a new expression.
This variable is useless since it's used nowhere, but if we're going
to have it we should have it act sanely.

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/3899caf772c8dec5c79e553c91f8fc248ca686c9

Modified Files
--------------
src/bin/pgbench/exprscan.l | 13 ++++++++-----
1 file changed, 8 insertions(+), 5 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2016-03-07 02:45:40 pgsql: Re-fix broken definition for function name in pgbench's exprscan
Previous Message Tom Lane 2016-03-07 01:49:27 Re: pgsql: logical decoding: Tell reorderbuffer about all xids.