pgsql: Make new isolationtester test more stable

From: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Make new isolationtester test more stable
Date: 2016-02-29 19:36:03
Message-ID: E1aaTbv-0007YR-Bl@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Make new isolationtester test more stable

The original coding of the test was relying too much on the ordering in
which backends are awakened once an advisory lock which they wait for is
released. Change the code so that each backend uses its own advisory
lock instead, so that the output becomes stable. Also add a few seconds
of sleep between lock releases, so that the test isn't broken in
overloaded buildfarm animals, as suggested by Tom Lane.

Per buildfarm members spoonbill and guaibasaurus.

Discussion: https://www.postgresql.org/message-id/19294.1456551587%40sss.pgh.pa.us

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/54638f5708e59e5fd7c79b8315d8c6e810d7bc13

Modified Files
--------------
src/test/isolation/expected/tuplelock-update.out | 26 +++++++++++++++++-------
src/test/isolation/specs/tuplelock-update.spec | 16 ++++++++++-----
2 files changed, 30 insertions(+), 12 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Alvaro Herrera 2016-02-29 19:42:09 Re: [COMMITTERS] pgsql: Add isolationtester spec for old heapam.c bug
Previous Message Tom Lane 2016-02-29 18:08:42 Re: pgsql: Add isolationtester spec for old heapam.c bug